Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit Adagrams code #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Submit Adagrams code #9

wants to merge 5 commits into from

Conversation

geneminde
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? The method signature and a code block
What are the advantages of using git when collaboratively working on one code base? Using git allows multiple users to work simultaneously on the same code while providing a mechanism to resolve conflicts generated while editing simultaneously.
What kind of relationship did you and your pair have with the unit tests? Our relationship with the test was great! It really helped us focus more granularly on our code's mechanics.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used .each and .include? The latter was helpful for identifying if a word was in the dictionary.
What was one method you and your pair used to debug code? Pair programming combined with TDD was so effective for us that we really didn't create any bugs, other than random typos, which we identified by looking at the error messages.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We mostly discussed how we wanted to use the time we had together in a maximally efficient manner. For us this meant verbally working through the problem, reaching a consensus, and then typing out the code.

iris-lux pushed a commit to iris-lux/adagrams that referenced this pull request Sep 18, 2020
@tildeee
Merge pull request Ada-C14#9 from AdaGold/ddr/rubric
8e15fa6 
rubric: new format, comp qs -> reflection
CheezItMan
CheezItMan reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit the learning goals here. Well done.

lib/adagrams.rb
@@ -0,0 +1,86 @@
require 'csv'

def draw_letters()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/adagrams.rb
return hand
end

def uses_available_letters?(input, letters_in_hand)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/adagrams.rb
return true
end

def score_word(word)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I love the use of a hash here.

lib/adagrams.rb
Comment on lines +83 to +86
def is_in_english_dict?(input)
dict = CSV.read('assets/dictionary-english.csv')
dict.include?([input.downcase]) ? true : false
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very compact and readable.

lib/adagrams.rb
return score
end

def highest_score_from(words)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geneminde @CheezItMan